Coda File System

Re: coda client hangs

From: Jan Harkes <jaharkes_at_cs.cmu.edu>
Date: Thu, 26 May 2005 14:18:29 -0400
On Thu, May 26, 2005 at 11:37:56AM -0600, Patrick Walsh wrote:
> 	Thank you, Jan!  I've put the patch in place and now we will just have
> to wait and see how it goes.  Hopefully this takes care of it.  Our
> stress tests on the system start next week...

I also figured out why we were calling the reset loop twice.

My guess is that the server clocks are off by a couple of seconds and
the new token is rejected by one of the servers because local time is
earlier than the BeginTimestamp value in the token. This also explains
why you seem to be losing tokens.

I don't really know why tokens have a BeginTimestamp, but disabling that
part of the test seems logical. The following patch will make sure that
the server doesn't reject tokens that haven't 'started' yet.

Jan

Index: coda-src/auth2/avice.c
===================================================================
RCS file: /afs/cs/project/coda-src/cvs/coda/coda-src/auth2/avice.c,v
retrieving revision 4.14
diff -u -u -r4.14 avice.c
--- avice.c	6 Feb 2004 18:55:28 -0000	4.14
+++ avice.c	26 May 2005 18:15:25 -0000
@@ -180,7 +180,7 @@
     ntoh_SecretToken(&st);
     
     gettimeofday(&t, 0);
-    if (t.tv_sec < st.BeginTimestamp || t.tv_sec > st.EndTimestamp) {
+    if (t.tv_sec > st.EndTimestamp) {
 	LogMsg(10, SrvDebugLevel, stdout,
 	       "End time stamp %d > time %d for user %d",
 		st.EndTimestamp,t.tv_sec,st.ViceId);
Received on 2005-05-26 14:19:17