Coda File System

Patch against SEGV (Was: Announcing coda release 5.2.4)

From: Andreas J. Koenig <andreas.koenig_at_anima.de>
Date: 14 Jun 1999 22:07:36 +0200
>>>>> On 14 Jun 1999 13:24:42 +0200, andreas.koenig_at_anima.de (Andreas J. Koenig) said:

>>>>> On Sat, 5 Jun 1999 10:09:17 -0400, Jan Harkes <jaharkes_at_cs.cmu.edu> said:
>> * Protection database fileformat changed to use libdb1.85.

 > Does anybody have advice on how this should be dealt with when
 > somebody has installed libdb 2.7.5 or any other version > 1.85?

 > I see unsatisficing incompatibilities. At least the RPM version of
 > pdbtool dumps core with my libdb 2.7.5 and so I cannot talk to codasrv
 > at all.

Here is a fix. Berkeley 1.85 tolerates this call with arg NULL, but
the 2.7.5 compatibility mode doesn't.

--- coda-src/al/pdbdb.c~	Mon Jun 14 21:32:57 1999
+++ coda-src/al/pdbdb.c	Mon Jun 14 21:33:47 1999
@@ -341,7 +341,7 @@
 	DB *db;
 	int rc1, rc2;
 	struct stat buf;
-	DBT key;
+	DBT key, value;
 	char zero = 0;
 	int result;
    
@@ -373,7 +373,7 @@
 	}
 
 	/* check if the record exists */
-        result = db->get(db, &key, NULL, 0);
+        result = db->get(db, &key, &value, 0);
         db->close(db);
    
 	if ( result != RET_SUCCESS ) {



Thanks,
-- 
andreas
Received on 1999-06-14 16:08:52